Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-6915 Changes to check the PR description, and adding some context to PR template. #15202

Merged
merged 2 commits into from
May 9, 2024

Conversation

AlexisErazoGlobant
Copy link
Contributor

@AlexisErazoGlobant AlexisErazoGlobant commented May 8, 2024

Purpose

Checker for Release Notes. It checks the following topics in the "Release Notes" section:

  1. Check if it's empty.
  2. Check if the text is the default one in the template.
  3. Check if there are non-applicable to Release Notes.
  4. Check if it has more than 6 words.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Checker for PR description. It checks the following topics in the "Release Notes" section:

  1. Check if it's empty.
  2. Check if the text is the default one in the template.
  3. Check if there are non-applicable to Release Notes.
  4. Check if it has more than 6 words.

Reviewers

@sm6srw

FYIs

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-6915

Copy link

github-actions bot commented May 8, 2024

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

@sm6srw sm6srw merged commit 8adde94 into DynamoDS:master May 9, 2024
27 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants