Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix extension assembly paths for linux #15227

Merged
merged 2 commits into from
May 17, 2024
Merged

Conversation

pinzart90
Copy link
Contributor

Issue:
Extensions assembly paths contain windows style dir separators. This is causing load issues on linux.

Purpose

Fix extension assembly paths when running on linux

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

(FILL ME IN) Brief description of the fix / enhancement. Use N/A to indicate that the changes in this pull request do not apply to Release Notes. Mandatory section

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

Copy link

github-actions bot commented May 17, 2024

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

Copy link
Member

@mjkkirschner mjkkirschner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm -
Looks ok but I hope there would be a cross platform unified way to do this.

also why was this not a problem last year?

@pinzart90
Copy link
Contributor Author

Hmm - Looks ok but I hope there would be a cross platform unified way to do this.

also why was this not a problem last year?

We could have this code fix run on both win and linux, but it would do redundant operations when running on windows.
Extensions are created on windows (for now) and the paths are windows stlye. We only need to make them linux compatible.

@pinzart90 pinzart90 merged commit 7d45f53 into master May 17, 2024
23 of 24 checks passed
@pinzart90 pinzart90 deleted the cross_os_extension_paths branch May 17, 2024 17:04
Enzo707 pushed a commit to Enzo707/Dynamo that referenced this pull request May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants