Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-7082 Update List.cs => IndexOf #15268

Closed
wants to merge 1 commit into from

Conversation

denizmaral
Copy link

@denizmaral denizmaral commented May 30, 2024

Purpose

The changes from #15205 require an update here. If the element is not in the list it should return null instead of -1.

https://jira.autodesk.com/browse/DYN-7082

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

DYN-7082 Update List.cs => IndexOf

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

the changes from DynamoDS#15205 require an update here. If the element is not in the list it should return null instead of -1.
@QilongTang QilongTang added this to the 3.3 milestone May 30, 2024
@QilongTang QilongTang changed the title Update List.cs => IndexOf DYN-7082 Update List.cs => IndexOf Jun 12, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7082

@QilongTang
Copy link
Contributor

@denizmaral Dynamo team appreciate your contribution, way to go!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants