Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-7015 ExecuteScriptFunctionAsync Crash Guard #15311

Merged
merged 2 commits into from
Jun 13, 2024

Conversation

QilongTang
Copy link
Contributor

@QilongTang QilongTang commented Jun 12, 2024

Purpose

From crash callstacks, looks like ExecuteScriptFunctionAsync call could rarely crash at https://github.com/DynamoDS/Dynamo/blob/RC3.0.3_master/src/LibraryViewExtensionWebView2/LibraryViewController.cs#L474, add code to guard that

Callstack:
image

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Add code to guard the fact ExecuteScriptFunctionAsync call could rarely crash in Library view

Reviewers

@DynamoDS/dynamo

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

@QilongTang QilongTang added this to the 3.3 milestone Jun 12, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7015

Copy link

github-actions bot commented Jun 12, 2024

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

@QilongTang
Copy link
Contributor Author

@QilongTang QilongTang merged commit c613519 into master Jun 13, 2024
27 of 28 checks passed
@QilongTang QilongTang deleted the ExecuteScriptAyncCrash branch June 13, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants