DYN-7038-Build-In-Packages-Duplicates #15315
Conversation
When loading a package that contains the extra/layoutSpecs.json file the nodes were showing duplicate in the Library and in the Add-Ons section. Then the fix was adding to ElementType the missing ElementTypes.BuiltIn when is in the Built-In dir.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7038
|
This is a screenshot showing the expected behavior when loading the DynamoATF package. |
UI Smoke TestsTest: success. 2 passed, 0 failed. |
|
Re-running the PR check to validate again |
|
I tested this and it works as expected. There is a test for the layoutspec. We can improve on it or add a new one. |
|
@BogdanZavu I think we can improve the test but I would get this merged first. The test should be adding NodeModel based node to the Signed Package example. That is produced in another repo but should be easy to get adjusted. |
|
@QilongTang Looks like test pass on the second run correct? |
Yup, https://master-5.jenkins.autodesk.com/job/Dynamo/job/DynamoSelfServe/job/pullRequestValidation/16190/ passed |
|
@RobertGlobant20 Please cherry-pick |
Purpose
Fixing duplicate package nodes in Library and Add-ons section
When loading a package that contains the extra/layoutSpecs.json file the nodes were showing duplicate in the Library and in the Add-Ons section. Then the fix was adding to ElementType the missing ElementTypes.BuiltIn when is in theBuilt-In Packages directory.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Fixing duplicate package nodes in Library and Add-ons section
Reviewers
@QilongTang @saintentropy
FYIs
@BogdanZavu