Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-4617 : use biginteger from pythonnet directly #15387

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

BogdanZavu
Copy link
Contributor

@BogdanZavu BogdanZavu commented Jul 11, 2024

Purpose

No need to have our own decoder and encoder anymore for the BigInteger since pythonnet 3.1.0 has added support for this.
Operations with BigInteger works as before in a python script in Dynamo.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Copy link
Contributor

@twastvedt twastvedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. Should there be a test on Dynamo side, or are the tests we have already in PythonNet enough?

@pinzart90
Copy link
Contributor

Are you planning to use the https://github.com/DynamoDS/Dynamo/tree/pythonnet_3.1.0 branch to implement all pythonnet3 changes ? Then take out the cpython project into a separate dynamo package ?

@pinzart90
Copy link
Contributor

Just to give another heads up, some of the changes that I made to https://github.com/DynamoDS/Dynamo/tree/pythonnet_3.1.0 have not been properly validated/tested.

@BogdanZavu
Copy link
Contributor Author

BogdanZavu commented Jul 12, 2024

Makes sense to me. Should there be a test on Dynamo side, or are the tests we have already in PythonNet enough?

I don't think so, what we have on python side should do it.

@BogdanZavu
Copy link
Contributor Author

Are you planning to use the https://github.com/DynamoDS/Dynamo/tree/pythonnet_3.1.0 branch to implement all pythonnet3 changes ?

I think so yes.

Then take out the cpython project into a separate dynamo package ?

Not sure but that sounds plausible, we have a task to decide on this.

@BogdanZavu
Copy link
Contributor Author

BogdanZavu commented Jul 12, 2024

Just to give another heads up, some of the changes that I made to https://github.com/DynamoDS/Dynamo/tree/pythonnet_3.1.0 have not been properly validated/tested.

We'll figure it out if something is not working but since you brought this up just to confirm : the changes related to pythonnet3.1 are your last 3 commits ?

@BogdanZavu BogdanZavu merged commit d867f14 into DynamoDS:pythonnet_3.1.0 Jul 12, 2024
20 of 23 checks passed
@BogdanZavu BogdanZavu deleted the DYN-4617 branch July 12, 2024 13:21
@pinzart90
Copy link
Contributor

Just to give another heads up, some of the changes that I made to https://github.com/DynamoDS/Dynamo/tree/pythonnet_3.1.0 have not been properly validated/tested.

We'll figure it out if something is not working but since you brought this up just to confirm : the changes related to pythonnet3.1 are your last 3 commits ?

Correct

BogdanZavu added a commit that referenced this pull request Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants