[DYN-7362] bugfix: prevent dynamo workspace paste execution when out of focus #15523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7362
Enzo707
changed the title
UI Smoke TestsTest: success. 11 passed, 0 failed. |
RobertGlobant20
approved these changes
Oct 7, 2024
| @@ -239,7 +239,6 @@ internal void RefreshLibraryView(WebView2 browser) | |||
| /// <param name="text">text to be added to clipboard</param> | |||
| internal void OnCopyToClipboard(string text) | |||
| { | |||
| dynamoViewModel.Model.ClipBoard.Clear(); | |||
There was a problem hiding this comment.
You added this line in #14998 for fixing the problem of copy/paste when using the mouse (click right copy and then click right paste).
if you remove it, will this produce a side-effect behavior on copy/paste using the mouse?
There was a problem hiding this comment.
@RobertGlobant20 It doesn't seems to cause any side effect, we manage two different Clipboard the native one and the one which is part of the model for storing the nodes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
ref.: [7362]
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Include an early return within DynamoView
OnRequestPasteinterrupting the execution when workspace is out of focus.Reviewers
@RobertGlobant20
@QilongTang