Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regressions Extra Node Info #15555

Merged
merged 3 commits into from
Oct 17, 2024
Merged

Regressions Extra Node Info #15555

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4de5d02
Fixing Regressions Extra Node Info
RobertGlobant20 Oct 16, 2024
6101275
Logging Regressions Extra Node Info
RobertGlobant20 Oct 17, 2024
b11a6ea
Logging Regressions Extra Node Info
RobertGlobant20 Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions test/DynamoCoreWpfTests/NodeAutoCompleteSearchTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ namespace DynamoCoreWpfTests
class NodeAutoCompleteSearchTests : DynamoTestUIBase
{

private readonly List<string> expectedNodes = new List<string> { "ByFillet", "ByFilletTangentToCurve", "ByGeometry", "ByMinimumVolume", "ByBlendBetweenCurves", "ByTangency", "ByLineAndPoint", "ByJoinedCurves", "ByThickeningCurveNormal", "ByLoft", "ByLoft", "ByLoftGuides", "BySweep", "ByLoft", "ByLoft", "ByRevolve", "BySweep", "BySweep2Rails", "ByLoft", "ByLoft", "ByPatch", "ByRevolve", "ByRuledLoft", "BySweep", "BySweep2Rails", "BuildFromLines", "BuildPipes", "ByExtrude", "ByPlaneLineAndPoint", "ByRevolve", "BySweep", "DoesIntersect", "IsAlmostEqualTo", "DistanceTo", "Intersect", "IntersectAll", "Project", "Project", "ProjectInputOnto", "ProjectInputOnto", "Split", "Trim", "SerializeAsSAB", "ClosestPointTo", "Join", "ByGroupedCurves", "SweepAsSolid", "ExportToSAT", "SweepAsSurface", "LocateSurfacesByLine", "BridgeEdgesToEdges", "BridgeEdgesToFaces", "BridgeFacesToEdges", "BridgeFacesToFaces", "CreateMatch", "ExtrudeEdgesAlongCurve", "ExtrudeFacesAlongCurve", "PullVertices" };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps sorting this list, and the found nodes alphabetically first would make sure we don't encounter any weirdness from results being in different orders.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, actually I think you're correct and it does not matter because except should not be affected by order, it's about sets, not lists.


[NodeDescription("This is test node with multiple output ports and types specified.")]
[NodeName("node with multi type outputs")]
[InPortNames("input1", "input2")]
Expand Down Expand Up @@ -166,7 +168,9 @@ public void NodeSuggestions_CanAutoCompleteOnCustomNodesOutPort_WithSpaceInPortN

// Results will be nodes that accept Line as parameter.
searchViewModel.PopulateAutoCompleteCandidates();
Assert.AreEqual(58, searchViewModel.FilteredResults.Count());
var nodeNamesResultList = searchViewModel.FilteredResults.Select(x => x.Name).ToList();

Assert.AreEqual(expectedNodes.Count(), nodeNamesResultList.Count(),string.Format("Missing nodes: {0} ", string.Join(", ",expectedNodes.Except(nodeNamesResultList))));
}
[Test]
public void NodeSuggestions_CanAutoCompleteOnCustomNodesOutPort_WithWhiteSpaceStartingPortName()
Expand All @@ -186,7 +190,9 @@ public void NodeSuggestions_CanAutoCompleteOnCustomNodesOutPort_WithWhiteSpaceSt

// Results will be nodes that accept Line as parameter.
searchViewModel.PopulateAutoCompleteCandidates();
Assert.AreEqual(58, searchViewModel.FilteredResults.Count());
var nodeNamesResultList = searchViewModel.FilteredResults.Select(x => x.Name).ToList();

Assert.AreEqual(expectedNodes.Count(), nodeNamesResultList.Count(), string.Format("Missing nodes: {0} ", string.Join(", ", expectedNodes.Except(nodeNamesResultList))));
}

[Test]
Expand Down
Loading