Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DYN-4361] Enable Ctrl + C to copy selected data out of preview bubbles/watch nodes #15559

Conversation

ivaylo-matov
Copy link
Contributor

Purpose

PR aims to address DYN-4361.

I have replaced TextBlock elements with TextBox controls in InfoBubbleView and WatchTree. Now users can select and copy data using Ctrl+C.
Note that for nodes with multiple warnings, the info bubble text boxes are wrapped in a Grid. The visual appearance is slightly different compared to the previous version (see image below). The change is small and helps avoid adding extra logic to the code-behind.

Before:

After:

DYN-4361-EnableCtrlC

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Users can now select data from info bubbles and Watch nodes and use Ctrl+C to copy.

Reviewers

@reddyashish
@QilongTang

FYIs

@dnenov
@Amoursol

changes only in views : TextBlock replaced with TextBox
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-4361

Copy link

github-actions bot commented Oct 18, 2024

UI Smoke Tests

Test: success. 11 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests

@reddyashish
Copy link
Contributor

reddyashish commented Oct 18, 2024

Code changes look good to me.
@hwahlstrom Any thoughts on this UI change to the error message text wrapping?
Also @ivaylo-matov noticed that the close button on the popup is not in the top right position.

@reddyashish
Copy link
Contributor

These 2 are failing, can you check?
Screenshot 2024-10-18 at 8 44 00 AM

updates the tests to take into account that the list items are now TextBox controls
@ivaylo-matov
Copy link
Contributor Author

@reddyashish , just updated the tests to take into account that the list items in the WatchTree are TextBox controls. The tests should now pass.

@hwahlstrom
Copy link
Collaborator

Code changes look good to me. @hwahlstrom Any thoughts on this UI change to the error message text wrapping? Also @ivaylo-matov noticed that the close button on the popup is not in the top right position.

The wrapping change is a good one.

@reddyashish reddyashish merged commit 74ecf97 into DynamoDS:master Oct 23, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants