Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-7466: padding factor #15561

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ivaylo-matov
Copy link
Contributor

@ivaylo-matov ivaylo-matov commented Oct 18, 2024

Purpose

Small PR related to DYN-7466 and feedback from the last Archilizer Check-in regarding nodes/groups appearing too large when zoom-to-fit is applied.

I've added a paddingFactor of 1.5 to WorkspaceViewModel.FitViewInternal. This adjustment affects zoom-to-fit behavior for node or group selections in TuneUp and Graph Node Manager, as well as for the Zoom to Fit button in workspace.

I think keeping paddingFactor as a local variable is appropriate, and the value of 1.5 seems reasonable. However, please let me know if this should be changed.

Before ---> ---> ---> After

Zoom-Node

Zoom-Group

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Padding factor added to zoom-to-fit, affecting TuneUp, Graph Node Manager, and the Zoom to Fit button.

Reviewers

@reddyashish
@QilongTang

FYIs

@dnenov
@Amoursol

@github-actions github-actions bot changed the title padding factor DYN-7466: padding factor Oct 18, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7466

Copy link

UI Smoke Tests

Test: success. 11 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests

@reddyashish
Copy link
Contributor

DynamoCoreWpfTests.NodeAutoCompleteSearchTests.NodeSuggestions_OutputPortBuiltInNode_AreCorrect is failing. Can you check it @ivaylo-matov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants