[DYN-7943] Custom node cannot be added to its own workspace. #15783
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7943
|
@reddyashish - customnodes actually can be safely added to their own workspace if a user utilizes the |
Then maybe we change the message to, the custom node cant be safely placed into the current custom node workspace without |
|
Thank you both. I have updated the message to let users know about using the scopeif node. I will check if this is breaking any existing packages. |
| { | ||
| var nodeGuid = Guid.Parse(nodeName); | ||
|
|
||
| if (nodeGuid.Equals(customNodeWorkspaceModel.CustomNodeId)) |
There was a problem hiding this comment.
I think @QilongTang was suggesting that in this check you iterate all the other nodes and make sure that one of them is scopeif OR you defer this check until they try to save the .dyf.
There was a problem hiding this comment.
if you wanted to get really fancy you could try to determine if they have the scope if hooked up correctly or at least in a topology where it has even a remote chance of working...
There was a problem hiding this comment.
Got it, looking into it.
There was a problem hiding this comment.
Updated the changes to look for the scopeif node in the custom node workspace and only then allow users to place the custom node in its own workspace. Modified the notification message accordingly.
As this freeze/hang happens mainly when that particular custom node instance is also present in the home workspace and is executed automatically, doing this check during saving the dyf wouldn't fix this case.
There was a problem hiding this comment.
what about also switching them into manual run mode when this occurs - I think we have a notification for this already under some circumstances? Maybe when using tuneup - or at least we did that previously.
There was a problem hiding this comment.
yes made the change to also set the homeworkspace to manual mode, when this case arises.
UI Smoke TestsTest: success. 11 passed, 0 failed. |
|
The only failing test RemovesScriptTagsFromLoadedHtml doesn't seem related to this. |
Purpose
https://jira.autodesk.com/browse/DYN-7943
Users were experiencing a Dynamo freeze when they try to add a custom node in its own workspace. This will cause an infinite loop and shouldn't be allowed as it is not a ideal use case.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
[DYN-7943] Custom node cannot be added to its own workspace.
Reviewers
@QilongTang @zeusongit