Skip to content

Conversation

@zeusongit
Copy link
Contributor

Purpose

(FILL ME IN) This section describes why this PR is here. Usually it would include a reference to the tracking task that it is part or all of the solution for.

Declarations

Check these if you believe they are true

Release Notes

(FILL ME IN) Brief description of the fix / enhancement. Use N/A to indicate that the changes in this pull request do not apply to Release Notes. Mandatory section

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

ivaylo-matov and others added 30 commits September 3, 2025 09:42
cpython still present but does not load
ivaylo-matov and others added 21 commits October 12, 2025 10:50
Update DynamoCore.csproj
Copilot AI review requested due to automatic review settings October 31, 2025 17:24
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request migrates Python node functionality from CPython3 to PythonNet3 engine within Dynamo. The change switches the default Python engine to PythonNet3, removes the legacy DSCPython library, and adds comprehensive user notification systems for the engine transition.

Key changes include:

  • Replacing CPython3 engine references with PythonNet3 throughout the codebase
  • Implementing user notifications for automatic engine upgrades
  • Updating test files to use PythonNet3 engine instead of CPython3

Reviewed Changes

Copilot reviewed 83 out of 96 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
test/core/python/*.dyn Updated Python test graphs to use PythonNet3 engine
test/Libraries/DynamoPythonTests/*.cs Migrated test code from DSCPython to DSPythonNet3 evaluator
src/Libraries/DSCPython/ Removed entire legacy CPython library implementation
src/DynamoCoreWpf/Views/Menu/PreferencesView.xaml Updated preferences UI for PythonNet3 engine reset
src/PythonMigrationViewExtension/ Enhanced migration extension with CPython upgrade notifications
src/Libraries/PythonNodeModels/PythonNode.cs Changed default engine from CPython3 to PythonNet3
src/DynamoCore/Configuration/PreferenceSettings.cs Added setting to hide CPython upgrade notifications
Files not reviewed (4)
  • src/DynamoCoreWpf/Properties/Resources.Designer.cs: Language not supported
  • src/Libraries/DSCPython/Properties/Resources.Designer.cs: Language not supported
  • src/Libraries/PythonNodeModels/Properties/Resources.Designer.cs: Language not supported
  • src/PythonMigrationViewExtension/Properties/Resources.Designer.cs: Language not supported
Comments suppressed due to low confidence (3)

test/Libraries/DynamoPythonTests/PythonEvalTestsWithLibraries.cs:1

  • [nitpick] The comment provides good context for the test quarantine, but could be more specific about the expected timeline for the "parity fix" or reference a tracking issue/ticket for resolution.
    test/Libraries/DynamoPythonTests/PythonEditTests.cs:1
  • [nitpick] Similar to the previous comment, this quarantine explanation would benefit from more specific details about the expected exception shape differences or a reference to a tracking issue for the parity fix.
    test/core/packageDependencyTests/PythonDependency.dyn:1
  • The Python dependency test should verify that the engine change from CPython3 to PythonNet3 doesn't break package dependency resolution, but the test file only shows the engine property change without corresponding test logic validation.

<PackageReference Include="Lucene.Net.QueryParser" Version="4.8.0-beta00016" />
<PackageReference Include="DynamoVisualProgramming.Analytics" Version="4.2.2.10200" />
<PackageReference Include="DynamoVisualProgramming.PythonEngine.PythonNet3" Version="1.4.3" GeneratePathProperty="true" ExcludeAssets="all" />
<PackageReference Include="DynamoVisualProgramming.Analytics" Version="4.2.1.9358" />
Copy link

Copilot AI Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The analytics package version was downgraded from 4.2.2.10200 to 4.2.1.9358. This appears to be unintentional and could indicate a dependency conflict that should be investigated.

Suggested change
<PackageReference Include="DynamoVisualProgramming.Analytics" Version="4.2.1.9358" />
<PackageReference Include="DynamoVisualProgramming.Analytics" Version="4.2.2.10200" />

Copilot uses AI. Check for mistakes.
@zeusongit zeusongit closed this Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants