Fix bug with Engine node #16675
Open
Fix bug with Engine node #16675
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the Engine node where list data validation was failing due to an incorrect type check. The node was checking for ArrayList specifically, but values serialized through ParseJSON(playerValue) via the Player do not return ArrayList instances, causing valid list data to be incorrectly rejected.
Key Changes:
- Updated type check from
ArrayListtoIEnumerableto support all enumerable collections
|
Is this PR aiming for 4.0 release or 4.1? Curious if there is a Jira task |
|
4.1 I think @QilongTang |
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The Graph Engine node is failing in some circumstances due to incorrect check. Currently the values pushed to DefineData via Player are serialized via
ParseJSON(playerValue);which does not return anArrayList.Declarations
Check these if you believe they are true
Release Notes
Engine node bug is fixed for supporting list data.
Reviewers
@twastvedt
FYIs