Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Root sample files, Dynamo 1.0 files #10

Merged
merged 4 commits into from
Feb 27, 2024
Merged

Root sample files, Dynamo 1.0 files #10

merged 4 commits into from
Feb 27, 2024

Conversation

dnenov
Copy link
Collaborator

@dnenov dnenov commented Feb 27, 2024

Purpose

A small PR fixing the render of files inside the root Sample folder. Additionally, adds custom rendering of the 'Author' field for recent files of older (xml) type.

UI Changes

image
image

Changes

  • files in the root Sample folder would now render normal size when in grid mode
  • custom rendering of the 'Author' field notifying the file is of old (XML) type for recent files

Reviewer

@QilongTang

- files in the root Sample folder would now render normal size when in grid mode
- custom rendering of the 'Auther' field notifying the file is of old (XML) type for recent files
@dnenov dnenov changed the title Root sample files Root sample files, Dynamo 1.0 files Feb 27, 2024
@QilongTang
Copy link
Collaborator

hi @dnenov Everytime you touch the repo affecting the Dynamo Home behavior, please increment the package version in package.json and do npm -install to update package-lock.json so we can publish new Github release and do npm publish of newer version of this pacakge

dnenov and others added 2 commits February 27, 2024 16:19
- swap 1.0 in favor of 1.x
- added hover to questionmark icon
@QilongTang
Copy link
Collaborator

Thanks @dnenov I am adding the version change myself.

@QilongTang QilongTang merged commit 73e1335 into master Feb 27, 2024
11 checks passed
@QilongTang QilongTang deleted the root-sample-files branch February 27, 2024 18:24
@dnenov
Copy link
Collaborator Author

dnenov commented Feb 27, 2024

hi @dnenov Everytime you touch the repo affecting the Dynamo Home behavior, please increment the package version in package.json and do npm -install to update package-lock.json so we can publish new Github release and do npm publish of newer version of this pacakge

Understood, @QilongTang!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants