Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-7034: Change default behavior pattern #22

Merged
merged 1 commit into from
May 29, 2024

Conversation

dnenov
Copy link
Collaborator

@dnenov dnenov commented May 29, 2024

Purpose

This PR addresses the following jira issue: https://jira.autodesk.com/browse/DYN-7034 Open and New dropdown button will not go back to the default behavior once the user chooses another option from the dropdown list

Changes

DynamoSandbox_71idkVIsDH

  • no longer 'remembers' the last default option used
  • now always defaults to the first option for the respective drop-down button

Reviewer

@reddyashish
@avidit

@@ -1,6 +1,6 @@
{
"name": "@dynamods/dynamo-home",
"version": "1.0.13",
Copy link
Contributor

@reddyashish reddyashish May 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are we changing the version here? the version on apphome repo is still 1.0.13?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh sorry i thought this was on dynamorepo.

@reddyashish reddyashish merged commit 4492c48 into master May 29, 2024
11 checks passed
@reddyashish reddyashish deleted the DYN-7034-remove-remember-default-action branch May 29, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants