Locale fix #9
Merged
Locale fix #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- removed old console.log messages - added en-US locale - (still) defaults to 'englishMessages' until more locales are added to the app - fixed dynamic font loading issue
This reverts commit 09450f1.
- removed old console.log messages - added en-US locale - (still) defaults to 'englishMessages' until more locales are added to the app - fixed dynamic font loading issue
QilongTang
reviewed
Feb 26, 2024
QilongTang
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Small code fixes. Added 'en-US' as a locale to complement the change in Dynamo HomePage.xaml.cs.
A fix to the placeholder for Artifakt font.
Changes
Reviewers
@QilongTang