Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group tests by model with the GroupByModel param #83

Closed
wants to merge 2 commits into from

Conversation

marchello2000
Copy link
Contributor

This address comments in #82

  • Tests in same fixture with same model path will run with the same model (without reopening the model)
  • Additional fixes:
    • Remember the directory for file pickers
    • Automatically set the working/results directory
    • Automatically infer the version of Revit to use from the assembly (based on the RevitAPI linked against)
    • Clean up a bunch of stale variables, update parts to modern C# standards
    • Fix by category grouping to show tests that aren't in a category

* Tests in same fixture with same model path will run with the same model (without reopening the model)
* Additional fixes:
    - Remember the directory for file pickers
    - Automatically set the working/results directory
    - Automatically infer the version of Revit to use from the assembly (based on the RevitAPI linked against)
    - Clean up a bunch of stale variables, update parts to modern C# standards
    - Fix by category grouping to show tests that aren't in a category
@marchello2000
Copy link
Contributor Author

Not sure what the contribution protocol is, so please let me know if you need me to do anything else.
Also, I wasn't able to figure out how you run UnitTests, still looking into it - but if you have suggestions, please let me know

@Garrett-R
Copy link

Tested on my machine and it works well.

@QilongTang
Copy link
Contributor

@ZiyunShang @AndyDu1985 @philxia1Do you have bandwidth to test the new changes in this PR?

@marchello2000
Copy link
Contributor Author

marchello2000 commented Jun 7, 2018

@QilongTang : I also have a bunch of additional nice changes in https://github.com/marchello2000/RevitTestFramework/ Happy to pull request those in. Also, I noticed a small bug with these changed yesterday as I was working on some other changes. Will update the PR shortly!

Update: committed the fix

…same fixture with same model path will run with the same model (without reopening the model) * Additional fixes: - Remember the directory for file pickers - Automatically set the working/results directory - Automatically infer the version of Revit to use from the assembly (based on the RevitAPI linked against) - Clean up a bunch of stale variables, update parts to modern C# standards - Fix by category grouping to show tests that aren't in a category
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants