DYN-6775 localizing tooltips splash screen #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the tooltips shown in the SplashScreen buttons are not being localized then I modified the code due that was a finger error when typing the property/state name for tooltips.
Using state.signInTooltip
|
This is a GIF showing the localized tooltips in the expected language. |
zeusongit
approved these changes
Apr 2, 2024
|
@RobertGlobant20 I believe you forgot to upgrade the package version |
@QilongTang I've submitte two PR, one is for updating the React SplashScreen project and the other is for updating the Dynamo SplashScreen version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Localization of tooltips in the SplashScreen button was not working due that the states had spelling problems then I did some changes and now the tooltips are shown in the expected language.