Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tool.drcacheoff.altbindir failing, suspect culprit is new tool.drcacheoff.tlb_simulator_v2p_basedir test #7245

Open
derekbruening opened this issue Feb 3, 2025 · 0 comments · May be fixed by #7246
Open

tool.drcacheoff.altbindir failing, suspect culprit is new tool.drcacheoff.tlb_simulator_v2p_basedir test #7245

derekbruening opened this issue Feb 3, 2025 · 0 comments · May be fixed by #7246
Assignees
@derekbruening
Labels
Component-DrMemtrace Component-Tests

Comments

@derekbruening
Copy link
Contributor

https://github.com/DynamoRIO/dynamorio/actions/runs/13115976186/job/36590233636

385: Test command: /opt/actions-runner/_work/dynamorio/dynamorio/build/build_release-external-64/bin64/runstats "-s" "90" "-killpg" "-silent" "-env" "LD_LIBRARY_PATH" "/opt/actions-runner/_work/dynamorio/dynamorio/build/build_release-external-64/lib64/release:/opt/actions-runner/_work/dynamorio/dynamorio/build/build_release-external-64/ext/lib64/release:" "-env" "DYNAMORIO_OPTIONS" "-stderr_mask 0xC -dumpcore_mask 0 -code_api" "/opt/actions-runner/_work/dynamorio/dynamorio/build/build_release-external-64/clients/bin64/drmemtrace_launcher" "-indir" "/opt/actions-runner/_work/dynamorio/dynamorio/build/build_release-external-64/drmemtrace.threadsig.aarch64" "-tool" "opcode_mix" "-alt_module_dir" "/opt/actions-runner/_work/dynamorio/dynamorio/clients/drcachesim/tests/drmemtrace.threadsig.aarch64.raw" "-module_file" "/opt/actions-runner/_work/dynamorio/dynamorio/build/build_release-external-64/drmemtrace.threadsig.aarch64/raw/modules.log"
385: Working Directory: /opt/actions-runner/_work/dynamorio/dynamorio/build/build_release-external-64/suite/tests
385: Test timeout computed to be: 120
385: Failed to open /opt/actions-runner/_work/dynamorio/dynamorio/build/build_release-external-64/drmemtrace.threadsig.aarch64/trace/drmemtrace.threadsig.16274.6003.trace.zip
385: Failed to initialize scheduler: Failed to open /opt/actions-runner/_work/dynamorio/dynamorio/build/build_release-external-64/drmemtrace.threadsig.aarch64/trace/drmemtrace.threadsig.16274.6003.trace.zip
385: ERROR: failed to initialize analyzer
 99/118 Test #385: code_api|tool.drcacheoff.altbindir ...............................***Failed  Required regular expression not found. Regex=[^Opcode mix tool results:
         126122 : total executed instructions
          15924 :     bcond
          15171 :       stp
.*
$
]  0.01 sec

It goes on to fail 2 more times for a red result in the retry-3x suite.

I'm looking at the test recently added right above it in the code which does:

    set(locdir ${PROJECT_BINARY_DIR}/drmemtrace.threadsig.aarch64)
    file(REMOVE_RECURSE ${locdir})
    file(MAKE_DIRECTORY ${locdir})

That's the same directory used by the altbindir test. Looks like the new test clobbers a directory this older test needs.
@derekbruening derekbruening mentioned this issue Feb 3, 2025
Merged
@derekbruening derekbruening self-assigned this Feb 3, 2025
derekbruening added a commit that referenced this issue Feb 3, 2025
@derekbruening
i#7245: Fix test race by using unique dirs
7bf4318 
Fixes a bug where the new tlb_simulator_v2p test used the same
directory as the existing altbindir test.  Both tests were then
clobbering each other's files.  This is solved by using unique names.

Further improves the altbindir test by dynamically removing the trace/
directory, since the test is supposed to test post-processing but
wasn't if run more than once in the same build directory.

Fixes #7245
@derekbruening derekbruening linked a pull request Feb 3, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@derekbruening derekbruening

Labels
Component-DrMemtrace Component-Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

i#7245: Fix test race by using unique dirs DynamoRIO/dynamorio
1 participant
@derekbruening