i#7245: Fix test race by using unique dirs #7246
Open
+23
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug where the new tlb_simulator_v2p test used the same directory as the existing altbindir test. Both tests were then clobbering each other's files. This is solved by using unique names. Further improves the altbindir test by dynamically removing the trace/ directory, since the test is supposed to test post-processing but wasn't if run more than once in the same build directory. Fixes #7245
edeiana
approved these changes
Feb 3, 2025
| # We are fine with a static config-time creation of the directory and the | ||
| # first test run creating the trace/ files with subsequent test runs re-using | ||
| # those files, as this test targets the tlb simulator. If our srcdir had | ||
| # trace/ file we would just use those. | ||
| file(REMOVE_RECURSE ${locdir}) | ||
| file(MAKE_DIRECTORY ${locdir}) | ||
| file(COPY ${srcdir}/raw DESTINATION ${locdir}/) |
There was a problem hiding this comment.
Oh, I thought every test had similar steps: set local dir, delete it, mkdir, copy files.
I didn't realize some tests do need clobbering.
Good catch, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where the new tlb_simulator_v2p test used the same directory as the existing altbindir test. Both tests were then clobbering each other's files. This is solved by using unique names.
Further improves the altbindir test by dynamically removing the trace/ directory, since the test is supposed to test post-processing but wasn't if run more than once in the same build directory.
Fixes #7245