Skip to content

Commit

Permalink
Correct Rubocop warnings manually
Browse files Browse the repository at this point in the history
  • Loading branch information
andrykonchin committed Aug 18, 2024
1 parent 3aebfe4 commit 191ecff
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 5 deletions.
3 changes: 3 additions & 0 deletions .rubocop_rspec.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,9 @@ RSpec/NestedGroups:
RSpec/ExpectInHook:
Enabled: false

RSpec/ExpectInLet:
Enabled: false

# NOTE: for many tests of equality `eql` works, while `be` does not, because
# expected #<Fixnum:...> => 101
# got #<BigDecimal:...> => 101.0 (0.101e3)
Expand Down
6 changes: 3 additions & 3 deletions dynamoid.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,9 @@ Gem::Specification.new do |spec|
spec.metadata['wiki_uri'] = 'https://github.com/Dynamoid/dynamoid/wiki'
spec.metadata['rubygems_mfa_required'] = 'true'

spec.add_runtime_dependency 'activemodel', '>=4'
spec.add_runtime_dependency 'aws-sdk-dynamodb', '~> 1.0'
spec.add_runtime_dependency 'concurrent-ruby', '>= 1.0'
spec.add_dependency 'activemodel', '>=4'
spec.add_dependency 'aws-sdk-dynamodb', '~> 1.0'
spec.add_dependency 'concurrent-ruby', '>= 1.0'

spec.add_development_dependency 'appraisal'
spec.add_development_dependency 'bundler'
Expand Down
4 changes: 2 additions & 2 deletions spec/dynamoid/criteria_new_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,10 @@
klass = new_class do
range :name
end
objects = klass.create([{ name: 'Alex' }, { name: 'Bob' }])

result = []
objects = klass.create([{ name: 'Alex' }, { name: 'Bob' }])
klass.each { |obj| result << obj }
klass.each { |obj| result << obj } # rubocop:disable Style/MapIntoArray

expect(result).to match_array(objects)
end
Expand Down

0 comments on commit 191ecff

Please sign in to comment.