Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix saving persisted model and delete item attributes with nil values #681

Merged
merged 1 commit into from
Aug 20, 2023

Conversation

andrykonchin
Copy link
Member

Fix saving persisted model and delete item attributes with nil values if config.store_attribute_with_nil_value = false.

The issue was introduced in #623 by switching from PutItem to UpdateItem for persisted models.

Closes #679

… if config.store_attribute_with_nil_value = false
@github-actions
Copy link

Code Coverage

Package Line Rate Health
dynamoid 90%
Summary 90% (2857 / 3162)

Minimum allowed line rate is 90%

@codecov
Copy link

codecov bot commented Aug 20, 2023

Codecov Report

Merging #681 (9da17f3) into master (7896f96) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 9da17f3 differs from pull request most recent head eb18c4a. Consider uploading reports for the commit eb18c4a to get more accurate results

@@            Coverage Diff             @@
##           master     #681      +/-   ##
==========================================
+ Coverage   90.33%   90.35%   +0.01%     
==========================================
  Files          62       62              
  Lines        3156     3162       +6     
==========================================
+ Hits         2851     2857       +6     
  Misses        305      305              
Files Changed Coverage Δ
...dynamoid/adapter_plugin/aws_sdk_v3/item_updater.rb 100.00% <100.00%> (ø)

@andrykonchin andrykonchin merged commit b2103d9 into master Aug 20, 2023
47 of 48 checks passed
@andrykonchin andrykonchin deleted the fix-updating-attributes-with-nil-values branch August 20, 2023 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating an attribute that is a key of a GSI to nil (3.9.0)
1 participant