Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transaction write update blocks #718

Merged
merged 5 commits into from
Mar 5, 2024

Conversation

ckhsponge
Copy link
Contributor

transaction write supports blocks for updates to allow incrementing a field or adding to or deleting from a set

Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.08%. Comparing base (cfa73ba) to head (6795cb5).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #718      +/-   ##
==========================================
+ Coverage   90.89%   91.08%   +0.18%     
==========================================
  Files          71       71              
  Lines        3414     3453      +39     
==========================================
+ Hits         3103     3145      +42     
+ Misses        311      308       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ckhsponge
Copy link
Contributor Author

@andrykonchin Here is another transaction write PR. Sorry if I'm flooding you! Feel free to delay if you want to release the other stuff first.

@ckhsponge
Copy link
Contributor Author

@andrykonchin This improves the transactions that got merged a few weeks ago.

README_transact.md Show resolved Hide resolved
lib/dynamoid/transaction_write/action.rb Outdated Show resolved Hide resolved
… to nil, removed documentation for upsert blocks
@ckhsponge
Copy link
Contributor Author

@andrykonchin I added the REMOVE and removed the docs for upsert blocks. I believe this covers all the feedback but please let me know if there's anything else. Thanks!

lib/dynamoid/transaction_write/action.rb Show resolved Hide resolved
spec/dynamoid/transaction_write/create_spec.rb Outdated Show resolved Hide resolved
spec/dynamoid/transaction_write/update_spec.rb Outdated Show resolved Hide resolved
spec/dynamoid/transaction_write/upsert_spec.rb Outdated Show resolved Hide resolved
README_transact.md Outdated Show resolved Hide resolved
README_transact.md Outdated Show resolved Hide resolved
@ckhsponge
Copy link
Contributor Author

@andrykonchin I clarified some contexts and removed some docs and tests for unsupported functionality. Let me know if I missed anything.

@andrykonchin
Copy link
Member

I will look at the changes a bit later.

@ckhsponge
Copy link
Contributor Author

@andrykonchin Just updated the PR with those issues.

@andrykonchin
Copy link
Member

Looks good. Thank you!

@andrykonchin andrykonchin merged commit 3fc2fc7 into Dynamoid:master Mar 5, 2024
58 of 60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants