-
-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect code sample of update method in readme.md #720
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #720 +/- ##
=======================================
Coverage 90.89% 90.89%
=======================================
Files 71 71
Lines 3414 3414
=======================================
Hits 3103 3103
Misses 311 311 ☔ View full report in Codecov by Sentry. |
Thank you! Could you please rebase the branch on master? |
…/dynamoid into update-sample-incorrect-in-readme
I’m sorry. Is this correct? |
Could you please squash all commits into one? I would do it myself and push with force into your branch but it seems it's not permitted. |
remove code sample that not exist as specifications in update method. remove code sample that not exist as specifications in update method. remove code sample that not exist as specifications in update method. remove code sample that not exist as specifications in update method.
…/dynamoid into update-sample-incorrect-in-readme
I'm sorry but I accidentaly broke branch. |
Hello, thank you for maintenance of this gem.
Probably related to issue #657.
I found what incorrect code sample of update method in readme.md.
.update
method does not accept conditions as arguments.dynamoid/lib/dynamoid/persistence.rb
Line 232 in 6b96d1d
Therefore, the following code as shown in the sample will fail.
So I removed this code sample.
thank you!