Remove venv from collection build

Dynatrace · Dec 19, 2024 · a00f64a · a00f64a
1 parent d567abd
commit a00f64a
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/galaxy.yml b/galaxy.yml
@@ -16,5 +16,6 @@ repository: https://github.com/Dynatrace/Dynatrace-OneAgent-Ansible
 documentation: https://docs.dynatrace.com/docs/setup-and-configuration/dynatrace-oneagent/deployment-orchestration/ansible
 build_ignore:
   - .github
+  - .pre-commit-config.yaml
   - .gitignore
-  - .pre-commit-config.yaml
+  - venv
diff --git a/roles/oneagent/tests/README.md b/roles/oneagent/tests/README.md
@@ -36,8 +36,7 @@ Upon downloading the collection
 $ apt-get install -y python3-venv python3-pip sshpass
 
 # Create virtual environment
-$ python -m venv venv
-$ source venv/bin/activate
+$ python -m venv venv && source venv/bin/activate
 
 # Install requirements
 $ pip install -r roles/oneagent/tests/requirements.txt

diff --git a/roles/oneagent/tests/resources/installers/Dynatrace-OneAgent-Linux.sh b/roles/oneagent/tests/resources/installers/Dynatrace-OneAgent-Linux.sh
@@ -63,7 +63,8 @@ deployUninstallScript() {
 }
 
 applyConfig() {
-	"${INSTALL_DIR}/agent/tools/${ONEAGENTCTL_BIN}" "${CTL_PARAMS}"
+	# shellcheck disable=SC2086
+	"${INSTALL_DIR}/agent/tools/${ONEAGENTCTL_BIN}" ${CTL_PARAMS}
 }
 
 main() {