Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parameterize protocol #540

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Parameterize protocol #540

merged 1 commit into from
Oct 4, 2023

Conversation

tobigremmer-dt
Copy link
Contributor

Resolves #539

@tobigremmer-dt tobigremmer-dt requested a review from a team as a code owner October 3, 2023 13:57
eemrdog
eemrdog approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@eemrdog eemrdog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok

@tobigremmer-dt tobigremmer-dt merged commit 02b7ea0 into dev Oct 4, 2023
@tobigremmer-dt tobigremmer-dt deleted the fix/539/gitlab-ingress-protocol branch October 4, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eemrdog eemrdog eemrdog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] GitLab ingress protocol not parameterized in role gitlab, task source-endpoints-external
2 participants
@tobigremmer-dt @eemrdog