Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/542/demo srg ownership #548

Merged
merged 4 commits into from
Oct 6, 2023
Merged

Fix/542/demo srg ownership #548

merged 4 commits into from
Oct 6, 2023

Conversation

tobigremmer-dt
Copy link
Contributor

Resolves #542

@tobigremmer-dt tobigremmer-dt requested a review from a team as a code owner October 5, 2023 14:11
eemrdog
eemrdog approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@eemrdog eemrdog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a quick note about the personal access token usage in case we would go with gitlab action. But this PR does not include that option, so it is ok.

...ollections/ace_box/ace_box/roles/demo-release-validation-srg-gitlab/files/monaco/srg/wf.json Outdated Show resolved Hide resolved
@tobigremmer-dt tobigremmer-dt merged commit 11d2a74 into dev Oct 6, 2023
2 checks passed
@tobigremmer-dt tobigremmer-dt deleted the fix/542/demo-srg-ownership branch October 6, 2023 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eemrdog eemrdog eemrdog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] demo-release-validation-srg-gitlab workflow broken
2 participants
@tobigremmer-dt @eemrdog