-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add technology parameter to filter copied files #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0sewa0
requested changes
Feb 4, 2025
Moved every way of copying to its own file. Went for a new to distinguish between the ways of copying by passing a copy function as parameter; We now either copy simple, by tech or do the atomic (per file) way
0sewa0
reviewed
Feb 5, 2025
0sewa0
reviewed
Feb 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested it, functionally LGTM:
- with
--technology=php
root@php-only-56d77fd9b8-zbv4l:/var/www/html# du -sh /opt/dynatrace/
195M /opt/dynatrace/
- without --technology=php
root@cm-all-677f997756-fdmsc:/var/www/html# du -sh /opt/dynatrace/
1.2G /opt/dynatrace/
left some comments due the logging being a bit lacking
Co-authored-by: Marcell Sevcsik <[email protected]>
Co-authored-by: Marcell Sevcsik <[email protected]>
0sewa0
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ticket
With this a new parameter is added:
technology
It is a comma separated list of technologies. If it is provided in a valid way, only those files will be copied over that have this technology. Namely, if the
manifest.json
looks like this (NOTE I assumed that the file has this structure, if it should not look like this please let me know.):and you filter by only
python
, only the files that are stored under the keypython
will be copied over.How can this be tested?
Unit tests are straight forward and test it properly IMO.