Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: unable to deploy app-detection-rules #1214

Merged
merged 1 commit into from
Oct 3, 2023
Merged

fix: unable to deploy app-detection-rules #1214

merged 1 commit into from
Oct 3, 2023

Conversation

warber
Copy link
Contributor

@warber warber commented Oct 3, 2023 •
edited
Loading

What this PR does / Why we need it:

Sometimes, the API returns 500 Internal Server Error e.g. when an application referenced by an application detection rule is not fully "ready" yet.

This PR adds another special treatment to handle that specific case.

@warber warber force-pushed the fix/app-detection-rule-500 branch from 365c2ee to 82cb32c Compare October 3, 2023 14:07
@warber warber marked this pull request as ready for review October 3, 2023 14:09
@warber warber requested a review from a team as a code owner October 3, 2023 14:09
@warber warber added the run-e2e-test Manually trigger the E2E tests for reviewed PRs label Oct 3, 2023
@warber warber force-pushed the fix/app-detection-rule-500 branch from 82cb32c to 4d28e66 Compare October 3, 2023 14:15
UnseenWizzard
UnseenWizzard previously approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@UnseenWizzard UnseenWizzard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay... more special retry rules :/

Laubi
Laubi previously approved these changes Oct 3, 2023
View reviewed changes
@github-actions
Copy link

github-actions bot commented Oct 3, 2023 •
edited
Loading

Test Results

       2 files  ±0     220 suites  ±0   18s ⏱️ -3s
1 511 tests ±0  1 511 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
3 022 runs  ±0  3 022 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit dcd8565. ± Comparison against base commit 7f30f23.

♻️ This comment has been updated with latest results.

@warber warber dismissed stale reviews from Laubi and UnseenWizzard via 1e5b3ad October 3, 2023 15:01
@warber warber force-pushed the fix/app-detection-rule-500 branch from 4d28e66 to 1e5b3ad Compare October 3, 2023 15:01
@warber warber force-pushed the fix/app-detection-rule-500 branch from 1e5b3ad to dcd8565 Compare October 3, 2023 15:04
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@warber warber merged commit 8ec0d7f into main Oct 3, 2023
@warber warber deleted the fix/app-detection-rule-500 branch October 3, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jskelin jskelin jskelin approved these changes

@UnseenWizzard UnseenWizzard UnseenWizzard left review comments

@Laubi Laubi Laubi left review comments

Assignees
No one assigned
Labels
run-e2e-test Manually trigger the E2E tests for reviewed PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@warber @jskelin @Laubi @UnseenWizzard