feat: load and parse account management resources #1235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warber
force-pushed
the
feat/load-acc-resources
branch
from
561dde1 to
8ac61c6
Compare
UnseenWizzard
requested changes
Oct 17, 2023
|
@UnseenWizzard I've improved the PR, pls take another look |
| // Load loads account management resources from YAML configuration files | ||
| // located within the specified root directory path. It parses the YAML files, extracts policies, | ||
| // groups, and users data, and organizes them into a AMResources struct, which is then returned. | ||
| func Load(fs afero.Fs, rootPath string) (*AMResources, error) { |
There was a problem hiding this comment.
I'd mark this as excluded from the gocognit check.
I've quickly tried if it would actually become nicer to read if we split out the parts into loadPolicies, loadGroups, .. methods. But with error handling still needed there's not much of a difference at all, actually it becomes messier to read.
There was a problem hiding this comment.
yes the "complexity" is absolutely manageable
UnseenWizzard
approved these changes
Oct 18, 2023
Signed-off-by: Bernd Warmuth <[email protected]>
…from disk Signed-off-by: Bernd Warmuth <[email protected]>
…aded AM resources Signed-off-by: Bernd Warmuth <[email protected]>
Signed-off-by: Bernd Warmuth <[email protected]>
Signed-off-by: Bernd Warmuth <[email protected]>
i decided that this is no error but just gives back empty resources. Signed-off-by: Bernd Warmuth <[email protected]>
warber
force-pushed
the
feat/load-acc-resources
branch
from
095e81e to
97ba2ad
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / Why we need it:
This PR introduces the capability to read account management resources from files living inside of monaco project folders. The PR contains a function responsible for loading raw resources into a first in-memory representation as well as a function validating the references between users groups and policies.
Special notes for your reviewer:
Does this PR introduce a user-facing change?