chore: Split up 'setup' task of Makefile #1242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UnseenWizzard
approved these changes
Oct 19, 2023
|
One note to this: originally, |
Laubi
force-pushed
the
chore/makefile-split-setup-task
branch
2 times, most recently
from
d8ae0b9 to
c05bbfd
Compare
Laubi
force-pushed
the
chore/makefile-split-setup-task
branch
from
c05bbfd to
2658978
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / Why we need it:
Currently, when executing any makefile task, we usually install all tools that we do use somewhere in the makefile. This is most inconvenient and slow.
This change does split up the setup step and moves the install calls to the targets where they're actually used.
Does this PR introduce a user-facing change?
No