refactor: remove getters in ClientSet

[jskelin]

Currently, all fields in ClientSet are public, and the getters don't contain any logic.

[github-actions]

Unit Test Results

1 911 tests  ±0   1 910 ✅ ±0   54s ⏱️ ±0s
  133 suites ±0       1 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit 6599719. ± Comparison against base commit 23db28c.

♻️ This comment has been updated with latest results.

[github-actions]

E2E Test Results

    4 files  ±0    268 suites  ±0   39m 25s ⏱️ + 2m 24s
2 016 tests ±0  2 014 ✅ +1  2 💤 ±0  0 ❌  - 1 
2 131 runs  ±0  2 129 ✅ +1  2 💤 ±0  0 ❌  - 1 

Results for commit b286e88. ± Comparison against base commit 533fe77.

♻️ This comment has been updated with latest results.

[tomazpu]

When searching over the whole project i see that the code still uses .Settings(). Please also check for all other getters.

Edit: checked in a call was a false positive with not so optimal naming of mocks in tests.

[jskelin]

When searching over the whole project i see that the code still uses .Settings(). Please also check for all other getters.

Edit: checked in a call was a false positive with not so optimal naming of mocks in tests.

There is no other appearance or method with the same name as the deleted getters

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud