-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(segments): download
functionality
#1647
Conversation
E2E Test Results 4 files - 1 270 suites - 131 41m 5s ⏱️ - 34m 1s Results for commit 0a55447. ± Comparison against base commit fe98181. This pull request removes 2 and adds 7 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
044f5dc
to
4bfc7a9
Compare
4bfc7a9
to
3686ffa
Compare
43b708f
to
ee8b7b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the unnecessary changes I commented: You can drop the single commit directly.
Please rename the wording to 'Segments' directly in this PR, as we already know the naming.
Something we need to fix somehow soonish is the aweful handling of the 'only' stuff. This does not scale. Nothing to do in this PR regarding this matter.
bca9e08
to
dd5c43b
Compare
download
functionality
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, from my side. Please still check with @Laubi about his comments.
1219eae
to
15d62f9
Compare
063a13f
to
4d65658
Compare
4d65658
to
6bd5af6
Compare
6bd5af6
to
f012cd8
Compare
f012cd8
to
a84aae5
Compare
Quality Gate failedFailed conditions |
Add support for downloading
segment
type. As part of the download process,uid
,version
andexternalId
are striped from the payload.When a flag
--only-segments
is added todownload
command, only configurations of typesegment
will be downloaded.