Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Rename filersegments -> segments #1652

Merged
merged 2 commits into from
Dec 16, 2024
Merged

refactor: Rename filersegments -> segments #1652

merged 2 commits into from
Dec 16, 2024

Conversation

jskelin
Copy link
Contributor

@jskelin jskelin commented Dec 13, 2024

The name of the feature is segment. With this PR, it is aligned with it.

@jskelin jskelin self-assigned this Dec 13, 2024
@jskelin jskelin requested a review from a team as a code owner December 13, 2024 15:38
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 13, 2024 •
edited
Loading

Unit Test Results

1 926 tests  ±0   1 925 ✅ ±0   54s ⏱️ ±0s
  133 suites ±0       1 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit be03531. ± Comparison against base commit fc5953a.

This pull request removes 5 and adds 5 tests. Note that renamed tests count towards both. 
github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/persistence/config/loader ‑ Test_parseConfigs/grail_filter-segment_config_with_FF_off
github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/persistence/config/loader ‑ Test_parseConfigs/grail_filter-segment_config_with_FF_on
github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/persistence/config/loader ‑ Test_parseConfigs/grail_filter-segment_written_as_api_config
github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/persistence/config/writer ‑ TestWriteConfigs/Grail_filter-segment
github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/persistence/config/writer ‑ TestWriteConfigs/Grail_filter-segment_should_fail_if_FF_MONACO_FILTER_SEGMENTS_is_not_set

github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/persistence/config/loader ‑ Test_parseConfigs/segment_config_with_FF_off
github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/persistence/config/loader ‑ Test_parseConfigs/segment_config_with_FF_on
github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/persistence/config/loader ‑ Test_parseConfigs/segment_written_as_api_config
github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/persistence/config/writer ‑ TestWriteConfigs/Segment_should_fail_if_FF_MONACO_FEAT_SEGMENTSis_not_set
github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/persistence/config/writer ‑ TestWriteConfigs/segment

♻️ This comment has been updated with latest results.

@Laubi Laubi changed the title Rename filersegments -> segments refactor: Rename filersegments -> segments Dec 16, 2024
@jskelin jskelin force-pushed the refactor/rename_to_segments branch 2 times, most recently from 7c4a9fa to 580a0ec Compare December 16, 2024 12:47
@jskelin jskelin force-pushed the refactor/rename_to_segments branch from 580a0ec to be03531 Compare December 16, 2024 12:55
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@jskelin jskelin merged commit ae4cec8 into main Dec 16, 2024
12 checks passed
@jskelin jskelin deleted the refactor/rename_to_segments branch December 16, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Laubi Laubi Laubi approved these changes

Assignees

@jskelin jskelin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jskelin @Laubi