Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make csidriver updateStrategy configurable #3383

Merged
merged 4 commits into from
Jul 1, 2024
Merged

Make csidriver updateStrategy configurable #3383

merged 4 commits into from
Jul 1, 2024

Conversation

0sewa0
Copy link
Contributor

@0sewa0 0sewa0 commented Jul 1, 2024

Description

https://dt-rnd.atlassian.net/browse/K8S-9601

Fixes: #2946

Make the updateStrategy part of the csi DaemonSet configurable via Helm.

How can this be tested?

make deploy/helm should use the defaults set in the values.yaml

  • play around with your own values.yaml

@0sewa0 0sewa0 added the helm Changes to helm templates or values file label Jul 1, 2024
@0sewa0 0sewa0 requested a review from a team as a code owner July 1, 2024 08:40
@codecov-commenter
Copy link

codecov-commenter commented Jul 1, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.30%. Comparing base (83801f6) to head (462c1d1).

Current head 462c1d1 differs from pull request most recent head 0b2bfd3

Please upload reports for the commit 0b2bfd3 to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3383   +/-   ##
=======================================
  Coverage   58.30%   58.30%           
=======================================
  Files         334      334           
  Lines       18686    18686           
=======================================
  Hits        10895    10895           
  Misses       6567     6567           
  Partials     1224     1224           
Flag Coverage Δ
unittests 58.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

luhi-DT
luhi-DT previously approved these changes Jul 1, 2024
Copy link
Collaborator

@luhi-DT luhi-DT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works for me!

@0sewa0 0sewa0 enabled auto-merge (squash) July 1, 2024 14:33
@0sewa0 0sewa0 merged commit 7b86405 into main Jul 1, 2024
14 checks passed
@0sewa0 0sewa0 deleted the helm/csi-upgrade branch July 1, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
helm Changes to helm templates or values file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configure UpdateStrategy on CSI Driver
4 participants