-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use -s param instead of "partial: ..." to generate partial manifests using Helm #3384
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3384 +/- ##
=======================================
Coverage 58.30% 58.30%
=======================================
Files 334 334
Lines 18686 18686
=======================================
Hits 10895 10895
Misses 6567 6567
Partials 1224 1224
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
config/helm/chart/default/templates/Common/crd/dynatrace-operator-crd.yaml
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything else LGTM
Description
K8S-9602
We want to generate only given parts of our Helm-chart for the release, and we used to do it by setting a "secret" param called
partial
, which led to a very overcomplicated and confusing logic.I replaced it with using the
-s
(--show-only
) in the makefiles instead.official docu:
Sidenote: I tried to make it "prettier" by trying not to list each CSI-related file 1-by-1, but didn't find a way (it's not pretty, but still much prettier than partial)-> 6d72c07How can this be tested?
Try out all helm/manifests related commands 😅 (no change in behaviour should be expected)
(Important to check not only the directly touched make commands, because all yaml files were touched do to the removal of the
partial
check)