Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use -s param instead of "partial: ..." to generate partial manifests using Helm #3384

Merged
merged 6 commits into from
Jul 1, 2024

Conversation

0sewa0
Copy link
Contributor

@0sewa0 0sewa0 commented Jul 1, 2024

Description

K8S-9602

We want to generate only given parts of our Helm-chart for the release, and we used to do it by setting a "secret" param called partial, which led to a very overcomplicated and confusing logic.

I replaced it with using the -s (--show-only) in the makefiles instead.
official docu:

 -s, --show-only stringArray                      only show manifests rendered from the given templates

Sidenote: I tried to make it "prettier" by trying not to list each CSI-related file 1-by-1, but didn't find a way (it's not pretty, but still much prettier than partial) -> 6d72c07

How can this be tested?

Try out all helm/manifests related commands 😅 (no change in behaviour should be expected)
(Important to check not only the directly touched make commands, because all yaml files were touched do to the removal of the partial check)

@0sewa0 0sewa0 added the helm Changes to helm templates or values file label Jul 1, 2024
@0sewa0 0sewa0 requested a review from a team as a code owner July 1, 2024 09:39
@codecov-commenter
Copy link

codecov-commenter commented Jul 1, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.30%. Comparing base (80011e5) to head (23a20dc).

Current head 23a20dc differs from pull request most recent head f52a094

Please upload reports for the commit f52a094 to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3384   +/-   ##
=======================================
  Coverage   58.30%   58.30%           
=======================================
  Files         334      334           
  Lines       18686    18686           
=======================================
  Hits        10895    10895           
  Misses       6567     6567           
  Partials     1224     1224           
Flag Coverage Δ
unittests 58.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@albertogdd albertogdd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything else LGTM

@0sewa0 0sewa0 enabled auto-merge (squash) July 1, 2024 13:05
@0sewa0 0sewa0 merged commit 83801f6 into main Jul 1, 2024
14 checks passed
@0sewa0 0sewa0 deleted the helm/fix-partial branch July 1, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
helm Changes to helm templates or values file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants