Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove arch param where necessary #4065

Merged
merged 8 commits into from
Nov 29, 2024
Merged

Remove arch param where necessary #4065

merged 8 commits into from
Nov 29, 2024

Conversation

0sewa0
Copy link
Contributor

@0sewa0 0sewa0 commented Nov 15, 2024

Description

DAQ-2193

Adds logic that it tries to define the most correct affinity for the deployed components.

  • only "tries" because we can't be sure of what architectures does a "custom image" support, but we will assume that the a "custom image" is a replicated public registry image.

So from now on if the ActiveGate or the OneAgent images are from the tenant-registry then only the amd64 nodes are supported according to the affinity.

  • This includes the "default scenario" (nothing is configured), and the "custom version" scenario (only a custom version is provided)

In all other cases ("custom image") we use the broader affinity, based on the public-registry images (amd64, arm64, ppc64le, s390x)

How can this be tested?

  • Deploy OnaAgent and ActiveGate with default/custom-version ==> only amd64 in the affinity
  • Deploy OnaAgent and ActiveGate with custom image ==> broader affinity used
    • images: public.ecr.aws/dynatrace/dynatrace-oneagent:1.303.55.20241122-143001, public.ecr.aws/dynatrace/dynatrace-activegate:1.303.25.20241118-125000
  • Downloaded codemodules respect the architecture of the Operator image.

@0sewa0 0sewa0 added the core Changes to core functionality of the Operator label Nov 15, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 71.21212% with 19 lines in your changes missing coverage. Please review.

Project coverage is 64.38%. Comparing base (4d01742) to head (28e5c15).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
test/mocks/pkg/clients/dynatrace/client.go 15.38% 8 Missing and 3 partials ⚠️
pkg/clients/dynatrace/agent_version.go 71.42% 3 Missing and 1 partial ⚠️
pkg/clients/dynatrace/endpoints.go 73.33% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4065      +/-   ##
==========================================
- Coverage   64.45%   64.38%   -0.07%     
==========================================
  Files         399      399              
  Lines       26735    26712      -23     
==========================================
- Hits        17232    17199      -33     
- Misses       8150     8158       +8     
- Partials     1353     1355       +2     
Flag Coverage Δ
unittests 64.38% <71.21%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@0sewa0 0sewa0 marked this pull request as ready for review November 26, 2024 09:23
@0sewa0 0sewa0 requested a review from a team as a code owner November 26, 2024 09:23
pkg/clients/dynatrace/agent_version.go Outdated Show resolved Hide resolved
pkg/clients/dynatrace/agent_version.go Outdated Show resolved Hide resolved
@0sewa0 0sewa0 enabled auto-merge (squash) November 29, 2024 10:39
Copy link
Contributor

@gkrenn gkrenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment, approved

pkg/clients/dynatrace/endpoints.go Show resolved Hide resolved
@0sewa0 0sewa0 merged commit f85df8f into main Nov 29, 2024
15 checks passed
@0sewa0 0sewa0 deleted the fix/no-arch-param branch November 29, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Changes to core functionality of the Operator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants