-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove arch param where necessary #4065
Conversation
70ce99a
to
264f5bc
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #4065 +/- ##
==========================================
- Coverage 64.45% 64.38% -0.07%
==========================================
Files 399 399
Lines 26735 26712 -23
==========================================
- Hits 17232 17199 -33
- Misses 8150 8158 +8
- Partials 1353 1355 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
264f5bc
to
a84c533
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment, approved
Description
DAQ-2193
Adds logic that it tries to define the most correct affinity for the deployed components.
So from now on if the ActiveGate or the OneAgent images are from the tenant-registry then only the
amd64
nodes are supported according to the affinity.version
is provided)In all other cases ("custom image") we use the broader affinity, based on the public-registry images (amd64, arm64, ppc64le, s390x)
How can this be tested?
public.ecr.aws/dynatrace/dynatrace-oneagent:1.303.55.20241122-143001
,public.ecr.aws/dynatrace/dynatrace-activegate:1.303.25.20241118-125000