Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes 'make manifests' bug caused by overwritten generate_manifest definition #4116

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

aorcholski
Copy link
Contributor

@aorcholski aorcholski commented Nov 27, 2024

JIRA

Description

The platform argument was set to openshift for both platforms:

[]$ make manifests/openshift
...
helm template dynatrace-operator config/helm/chart/default ... --set platform="openshift" ... > config/deploy/openshift/openshift.yaml
[]$ make manifests/kubernetes
...
helm template dynatrace-operator config/helm/chart/default ... --set platform="openshift" ... > config/deploy/kubernetes/kubernetes.yaml

How can this be tested?

Run make manifests/* commands. Check value of the platform argument:

helm template dynatrace-operator config/helm/chart/default ... --set platform="openshift" ... > config/deploy/openshift/openshift.yaml

make manifests/kubernetes sets platform argument to kubernetes

make manifests/openshift sets platform argument to openshift

@aorcholski aorcholski added the core Changes to core functionality of the Operator label Nov 27, 2024
@aorcholski aorcholski requested a review from a team as a code owner November 27, 2024 13:40
@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.45%. Comparing base (b12cb0c) to head (5c2d6b1).
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4116   +/-   ##
=======================================
  Coverage   64.45%   64.45%           
=======================================
  Files         399      399           
  Lines       26735    26735           
=======================================
  Hits        17232    17232           
  Misses       8150     8150           
  Partials     1353     1353           
Flag Coverage Δ
unittests 64.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andriisoldatenko andriisoldatenko self-requested a review November 28, 2024 12:55
@aorcholski aorcholski merged commit 359796f into main Nov 28, 2024
20 checks passed
@aorcholski aorcholski deleted the bugfix/make-manifest branch November 28, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Changes to core functionality of the Operator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants