Cherry-pick: Change readonly oneAgent + custom image validation to a warning #4346 #4386
+58
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waodim
added
the
cherrypick
waodim
requested review from
andriisoldatenko,
gkrenn,
0sewa0,
chrismuellner,
StefanHauth and
aorcholski
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #4386 +/- ##
=======================================
Coverage 64.54% 64.55%
=======================================
Files 406 406
Lines 26870 26875 +5
=======================================
+ Hits 17343 17348 +5
Misses 8206 8206
Partials 1321 1321
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
StefanHauth
previously requested changes
Jan 31, 2025
0sewa0
previously approved these changes
Feb 3, 2025
waodim
changed the title
0sewa0
approved these changes
Feb 7, 2025
andriisoldatenko
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
same as #4346
How can this be tested?
same as in #4346