Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create and add OpenSignal API credentials secret to OTelC pod #4507

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

andriisoldatenko
Copy link
Contributor

@andriisoldatenko andriisoldatenko commented Feb 25, 2025

Description

How can this be tested?

@codecov-commenter
Copy link

codecov-commenter commented Feb 25, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 56.14035% with 50 lines in your changes missing coverage. Please review.

Project coverage is 64.89%. Comparing base (12ef55b) to head (494b504).
Report is 21 commits behind head on main.

Files with missing lines Patch % Lines
...kg/controllers/dynakube/otelc/secret/reconciler.go 55.44% 33 Missing and 12 partials ⚠️
pkg/controllers/dynakube/otelc/reconciler.go 40.00% 2 Missing and 1 partial ⚠️
pkg/api/v1beta3/dynakube/telemetryservice_props.go 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4507      +/-   ##
==========================================
- Coverage   64.91%   64.89%   -0.03%     
==========================================
  Files         413      414       +1     
  Lines       27253    27359     +106     
==========================================
+ Hits        17692    17755      +63     
- Misses       8233     8264      +31     
- Partials     1328     1340      +12     
Flag Coverage Δ
unittests 64.89% <56.14%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andriisoldatenko andriisoldatenko changed the title add opensignal apicreds secret Create and add OpenSignal API credentials secret to OTelC pod Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants