Fix Lint/SendWithMixinArgument cop

Dynflow · Jan 31, 2024 · 1639598 · 1639598
1 parent 07ee874
commit 1639598
Show file tree

Hide file tree

Showing 5 changed files with 4 additions and 16 deletions.
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
@@ -91,15 +91,6 @@ Lint/ScriptPermission:
     - 'examples/memory_limit_watcher.rb'
     - 'examples/sub_plan_concurrency_control.rb'
 
-# Offense count: 4
-# Cop supports --auto-correct.
-Lint/SendWithMixinArgument:
-  Exclude:
-    - 'lib/dynflow.rb'
-    - 'lib/dynflow/debug/telemetry/persistence.rb'
-    - 'test/activejob_adapter_test.rb'
-    - 'test/executor_test.rb'
-
 # Offense count: 3
 Lint/ShadowingOuterLocalVariable:
   Exclude:

diff --git a/lib/dynflow.rb b/lib/dynflow.rb
@@ -79,10 +79,7 @@ def self.from_hash(hash)
 
     class Railtie < ::Rails::Railtie
       config.before_initialize do
-        ::ActiveJob::QueueAdapters.send(
-          :include,
-          Dynflow::ActiveJob::QueueAdapters
-        )
+        ::ActiveJob::QueueAdapters.include Dynflow::ActiveJob::QueueAdapters
       end
     end
   end

diff --git a/lib/dynflow/debug/telemetry/persistence.rb b/lib/dynflow/debug/telemetry/persistence.rb
@@ -41,4 +41,4 @@ module Persistence
   end
 end
 
-::Dynflow::Persistence.send(:prepend, ::Dynflow::Debug::Persistence)
+::Dynflow::Persistence.prepend ::Dynflow::Debug::Persistence
diff --git a/test/activejob_adapter_test.rb b/test/activejob_adapter_test.rb
@@ -22,7 +22,7 @@ def perform(msg)
     end
 
     before(:all) do
-      ::ActiveJob::QueueAdapters.send(:include, ::Dynflow::ActiveJob::QueueAdapters)
+      ::ActiveJob::QueueAdapters.include ::Dynflow::ActiveJob::QueueAdapters
       ::ActiveJob::Base.queue_adapter = :dynflow
       dynflow_mock = Minitest::Mock.new
       dynflow_mock.expect(:world, world)

diff --git a/test/executor_test.rb b/test/executor_test.rb
@@ -18,7 +18,7 @@ def wait_for_orchestrator_lock; end
   def reacquire_orchestrator_lock; end
 end
 
-::Dynflow::Executors::Sidekiq::Core.send(:prepend, RedisMocks)
+::Dynflow::Executors::Sidekiq::Core.prepend RedisMocks
 
 module Dynflow
   module ExecutorTest