extract code from print_cfl into dss_hvtensor routine #6723
+112
−74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HOMME fortran init code refactor: important code hidden in print_cfl() is extracted into a new routine, dss_hvtensor dss_hvtensor improves HV results by making the HV coefficients smooth accross elements. It also does a bilinear projection of the coefficients within each element to minimize oscillations in the tensor coefficieints.
tcclevenger
approved these changes
Nov 13, 2024
|
@tcclevenger I think this is ready |
|
@rljacob Currently trying to setup homme standalone tests to verify this fix. Will merge to next once I complete that. |
tcclevenger
added a commit
that referenced
this pull request
Jan 2, 2025
HOMME fortran init code refactor: important code hidden in print_cfl() is extracted into a new routine, dss_hvtensor. dss_hvtensor improves HV results by making the HV coefficients smooth accross elements. It also does a bilinear projection of the coefficients within each element to minimize oscillations in the tensor coefficieints. [BFB]
|
Merged to next |
|
I suspect this PR could be the reason for all the testing DIFFs. Reverting from next to investigate. |
|
one guess: keep the new routine in the original file, global_norms_mod.F90, so it will be compiled with the same optimization. |
Normalized errors seem to be too high for just optimization differences. I'm seeing them as large as 2e+1 in some cases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HOMME fortran init code refactor: important code hidden in print_cfl() is extracted into a new routine, dss_hvtensor
dss_hvtensor improves HV results by making the HV coefficients smooth accross elements. It also does a bilinear projection of the coefficients within each element to minimize oscillations in the tensor coefficieints.
[BFB]