Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflows: reorganization after EAMxx merge-in #6775

Merged
merged 7 commits into from
Nov 27, 2024

Conversation

mahf708
Copy link
Contributor

@mahf708 mahf708 commented Nov 23, 2024

upgrades the underlying container for testing, remove redundancies and improve things due to the EAMxx merge-in.

@mahf708 mahf708 added Documentation Testing Anything related to unit/system tests MMF EAMxx PRs focused on capabilities for EAMxx labels Nov 23, 2024
@mahf708 mahf708 requested review from rljacob and bartgol November 23, 2024 15:19
Copy link

github-actions bot commented Nov 23, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://E3SM-Project.github.io/E3SM/pr-preview/pr-6775/
on branch gh-pages at 2024-11-26 01:44 UTC

@mahf708 mahf708 linked an issue Nov 23, 2024 that may be closed by this pull request
@mahf708 mahf708 force-pushed the mahf708/eamxx/gh-ci-cleanup branch from 9a51901 to 9a29e2e Compare November 23, 2024 16:55
@mahf708 mahf708 removed the MMF label Nov 23, 2024
Copy link
Contributor

@bartgol bartgol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were you planning to delete components/eamxx/cime_config/tests/eamxx_default_files.py as well?

@mahf708
Copy link
Contributor Author

mahf708 commented Nov 25, 2024

Were you planning to delete components/eamxx/cime_config/tests/eamxx_default_files.py as well?

I thought about that, but I stopped short because maybe it is helpful to keep it? What do you prefer? I can push another commit and delete it. Let me know

@bartgol
Copy link
Contributor

bartgol commented Nov 25, 2024

I'm debated too. But since it's meant for automation, and we're removing the automation, I would be for pruning that script (along with the empty tests folder left behind) altogether.

I grew a certain reluctance to keep around scripts that are not used...

@mahf708 mahf708 requested a review from bartgol November 26, 2024 01:43
@bartgol bartgol added the CI: workflow change approved Allow testing on ghci-snl-* machines of PRs that alter a worfklow file label Nov 27, 2024
@bartgol
Copy link
Contributor

bartgol commented Nov 27, 2024

Same fails as in master (under investigation by the mam4xx team). Merging.

@bartgol bartgol merged commit 744cb2c into master Nov 27, 2024
18 of 21 checks passed
@bartgol bartgol deleted the mahf708/eamxx/gh-ci-cleanup branch November 27, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: workflow change approved Allow testing on ghci-snl-* machines of PRs that alter a worfklow file Documentation EAMxx PRs focused on capabilities for EAMxx Testing Anything related to unit/system tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants