Calculate fluxes in MOAB coupler with MOAB data #6996
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new shr_moab_mod file that will contain usefule moab-based functions and subroutines. First 3: mbGetnCells, mbGetTagVals, mbSetTagVals
Convert seq_flux_atmocn_mct to use MOAB data. The local fortran arrays are sized according to number of points locally in MOAB. Arrays are intialized from MOAB app and results are copied directly to a MOAB app. MCT-based fluxes are never set.
Rename seq_flux_atmocn_mct in moab coupler to seq_flux_atmocn_moab and remove the old moab version
Convert seq_flux_ocnalb to use MOAB data. Create new local fortran arrays to perform calculations. Fill from MOAB apps and copy to MOAB apps MCT-based fluxes and albedos are not set
|
Note: once this is merged, the MOABCOMP output will show diffs for the flux fields since the MCT versions are always 0. |
|
Converted back to draft because want to merge after #7015 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calculate fluxes and ocean albedos in MOAB coupler with data in the MOAB meshes.
Prior to this change, the fluxes were calculated with MCT data and then copied to MOAB data structures.
Verified by inspection of xao fields before and after this change using Visit.
[BFB]