Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CDAT Migration Phase 2: Refactor streamflow set #837

Merged
merged 15 commits into from
Aug 26, 2024
Merged

CDAT Migration Phase 2: Refactor streamflow set #837

merged 15 commits into from
Aug 26, 2024

Commits on Aug 22, 2024

  1. Add testing setup

    @tomvothecoder
    tomvothecoder committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    7281061 View commit details
    Browse the repository at this point in the history

  2. Initial driver refactoring

    @tomvothecoder
    tomvothecoder committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    cbe03e8 View commit details
    Browse the repository at this point in the history

  3. Refactor _run_diags() and child functions 

    - Extract `_get_gauges()` function
- Rename `setup_test()` to `_get_test_data_and_area_upstream()`
- Renme `setup_ref()` to `_get_ref_data()`
- Extract `_get_var_data()` function
- Start refactoring `_generate_export()` function
    @tomvothecoder
    tomvothecoder committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    71c6f93 View commit details
    Browse the repository at this point in the history

  4. Start refactoring plotters

    @tomvothecoder
    tomvothecoder committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    c306d9e View commit details
    Browse the repository at this point in the history

  5. Split up streamflow plots into separate modules

    @tomvothecoder
    tomvothecoder committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    c2f9e2d View commit details
    Browse the repository at this point in the history

  6. Clean up seasonality plot;

    @tomvothecoder
    tomvothecoder committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    b4d59b5 View commit details
    Browse the repository at this point in the history

  7. Refactor streamflow_plot_map

    @tomvothecoder
    tomvothecoder committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    809bfb3 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2024

  1. Fix incorrect sizing of seasonality map markers

    @tomvothecoder
    tomvothecoder committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    f743c16 View commit details
    Browse the repository at this point in the history

  2. Various code cleanup changes 

    - Add docstrings and type annotations
- Reorder function arguments
- Remove unnecessary exception raises
    @tomvothecoder
    tomvothecoder committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    d7d056c View commit details
    Browse the repository at this point in the history

  3. Clean up driver

    @tomvothecoder
    tomvothecoder committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    ddf0d26 View commit details
    Browse the repository at this point in the history

  4. Update docstring for plotter

    @tomvothecoder
    tomvothecoder committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    aecf482 View commit details
    Browse the repository at this point in the history

  5. Remove unused regression_test.ipynb notebook

    @tomvothecoder
    tomvothecoder committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    8948f3c View commit details
    Browse the repository at this point in the history

  6. Apply suggestions from code review

    @tomvothecoder
    tomvothecoder authored Aug 26, 2024
    Configuration menu
    Copy the full SHA
    50cd0ec View commit details
    Browse the repository at this point in the history

  7. Apply suggestions from code review

    @tomvothecoder
    tomvothecoder authored Aug 26, 2024
    Configuration menu
    Copy the full SHA
    0c6e2ec View commit details
    Browse the repository at this point in the history

  8. Fix type annotation union

    @tomvothecoder
    tomvothecoder committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    5d947cd View commit details
    Browse the repository at this point in the history