avoid downloading data

[mahf708]

Description

• Closes Discussion about use of https://web.lcrc.anl.gov/ in CI #900
• See container definition in https://github.com/E3SM-Project/containers/tree/main/e3sm-diags

Instead of downloading the data, run the testing inside a container that has the data. See above for how the container was defined.

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• My changes generate no new warnings
• Any dependent changes have been merged and published in downstream modules

If applicable:

• New and existing unit tests pass with my changes (locally and CI/CD build)
• I have added tests that prove my fix is effective or that my feature works
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have noted that this is a breaking change for a major release (fix or feature that would cause existing functionality to not work as expected)

[xylar]

Thank you @mahf708, this is a very clean alternative!

[xylar]

A questionable use of your Saturday, however :-)

[chengzhuzhang]

@mahf708 I appreciate the timely solution! Could you provide some guidance on how to create new images when testing data need to be updated. I suppose the final step is to bump the image version in build_workflow.yml..

[mahf708]

@mahf708 I appreciate the timely solution! Could you provide some guidance on how to create new images when testing data need to be updated. I suppose the final step is to bump the image version in build_workflow.yml..

The info re image is in https://github.com/E3SM-Project/containers/tree/main/e3sm-diags. I copied the the download data functions from this repo (e3sm_diags) and so we would have to update that script and trigger a build. When there is a need to update them, we can submit a PR to https://github.com/E3SM-Project/containers. Most of the process is automated

[chengzhuzhang]

Most of the process is automated

This is great news! It just occurred to me that the container should be named as e3sm_diags_testing_data or some sort. With the name e3sm_diags it can be confusing, we had built e3sm_diags (the code base) Docker containers a a long time ago...

[xylar]

@mahf708, I agree with @chengzhuzhang's suggestion to rename the container. I initially assumed e3sm_diags contained the code itself and not just the test data, which had me concerned.

[xylar]

I decided to do my best in: E3SM-Project/containers#22