Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chicoma-gpu #187

Closed
wants to merge 3 commits into from
Closed

Conversation

altheaden
Copy link
Collaborator

@altheaden altheaden commented Jul 31, 2024

In this PR I added the necessary files to add chicoma-gpu to mache. The files for the nvidia and gnu compilers are symlinks to the existing chicoma-cpu files, while the nvidiagpu and gnugpu files are newly created.

Checklist

  • Testing comment in the PR documents testing used to verify the changes

closes #180

@altheaden
Copy link
Collaborator Author

@xylar will do testing on chicoma since I do not have access. It's likely that some changes still need to be done to the nvidiagpu and gnugpu files, but I did try to update them via what's in the config_machines.xml file to get things started.

@altheaden
Copy link
Collaborator Author

I realized after committing this that there is some documentation referencing the supported machines. I'll update that to include this machine as well and push that to this branch tomorrow.

@altheaden altheaden added documentation Improvements or additions to documentation enhancement New feature or request in progress This PR is not ready for review or merging labels Jul 31, 2024
@altheaden
Copy link
Collaborator Author

@xylar In regards to adding new machines to discover.py, do we want to add another regex to find chicoma-gpu from its hostname? I noticed that we don't have an entry for pm-gpu, so I'm unsure if we need a separate one from chicoma-cpu. If we do, I need to know what the hostnames look like for chicoma-gpu, I've looked at the documentation that I have access to but I can't find anything about it.

@xylar
Copy link
Collaborator

xylar commented Aug 1, 2024

@altheaden, no we can't do that because chicoma-cpu and chicoma-gpu (just as pm-cpu and pm-gpu) have the same login nodes so the hostname at least on the login nodes can't tell us which is which. We default to the -cpu version and make the user specify if they want the -gpu version.

@xylar
Copy link
Collaborator

xylar commented Aug 1, 2024

Thanks for asking, though!

@altheaden
Copy link
Collaborator Author

@xylar thanks! I realized that the documentation was referring to hostnames, so nothing needs to be updated for this PR after all, and my work here is done as far as I can tell.

@altheaden altheaden removed the documentation Improvements or additions to documentation label Aug 1, 2024
@xylar
Copy link
Collaborator

xylar commented Aug 5, 2024

@altheaden, I'm going to put this on hold until I get #188 working (hopefully not too long) since those changes will also apply here.

@xylar
Copy link
Collaborator

xylar commented Dec 3, 2024

This isn't a high priority for now.

@xylar xylar closed this Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request in progress This PR is not ready for review or merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add chicoma-gpu
2 participants