-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port drying slope test group from Compass and add new test to group #192
Draft
cbegeman
wants to merge
24
commits into
E3SM-Project:main
Choose a base branch
from
cbegeman:ocn-port-drying-slope
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add option to have forced convergence studies Add convergence input filename option
Use culled mesh and area-normalized error Support nans in convergence analysis Use init step argument
cbegeman
added
enhancement
New feature or request
in progress
This PR is not ready for review or merging
ocean
Related to ocean tests or analysis
labels
May 20, 2024
cbegeman
added
the
E3SM PR required
The polaris changes won't work with the current E3SM-Project submodule and require an update
label
May 20, 2024
This PR is on hold until baroclinic wetting and drying is available in E3SM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
E3SM PR required
The polaris changes won't work with the current E3SM-Project submodule and require an update
enhancement
New feature or request
in progress
This PR is not ready for review or merging
ocean
Related to ocean tests or analysis
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here we port the drying slope test group from Compass and add a new baroclinic test from O'Dea et al. (2021) which has linear drying and vertical stratification.
Checklist
api.md
) has any new or modified class, method and/or functions listedTesting
comment in the PR documents testing used to verify the changes