-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some CMake mods to LibFind and FindXYZ modules #444
Conversation
@bartgol :
|
"significantly" might be subjective, but the new impl sheds ~50 lines (out of ~300) off of |
I actually just found out that cmake picks up Edit: nvm, |
* Tell find_path to not search in default paths (which are scanned before what's supplied via the PATHS argument) * Tell find_path to also look in the include subdir of any of the provided paths (if present)
@dqwu @jayeshkrishna any interest in getting this PR move forward? If you guys don't approve/want these mods, feel free to close the PR. |
@dqwu please test out the fix on all E3SM machines. |
OK, I will make sure that it will not cause any regressions. |
Closing since this is stale. |
if
Find<PKG>.cmake
supports multiple components, avoiding calls tofind_package_handle_standard_args
insidefind_packagae_component
in LibFind.cmake. The calls are instead moved inside the
Find<PKG>.cmake
module (requesting to handle components).
This change removes several CMake developer warnings when finding
external packages.
Fixes #446