Fix release workflow not publishing latest tags for docs #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomvothecoder
commented
Jun 21, 2023
| @@ -4,6 +4,8 @@ on: | |||
| release: | |||
| types: [published] | |||
|
|
|||
| workflow_dispatch: | |||
There was a problem hiding this comment.
This line allows us to manually run workflows. We need to add this because the release workflow currently only triggers when releasing new versions. However, we want to run it manually to fix the v1.3.0 docs.
tomvothecoder
changed the title
tomvothecoder
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the E3SM Diags release workflow wasn't copying the docs for v2.8.0 over to the gh-pages branch (related PR). This caused the docs to break with a 404 if you tried clicking v2.8.0 in the dropdown.
The same thing is happening in zstash with v1.3.0. I updated the release workflow to correctly copy the tag docs. Once this is merged, we can rerun the release workflow manually to copy v1.3.0 docs over to gh-pages.
Note, another 1.4.0 release candidate is not required for this fix because this is DevOps related.